Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double message when trying to skip a mandatory wizard during #4525

Closed
foosel opened this issue May 25, 2022 · 3 comments · Fixed by #4561
Closed

Fix double message when trying to skip a mandatory wizard during #4525

foosel opened this issue May 25, 2022 · 3 comments · Fixed by #4561
Labels
approved Issue has been approved by the bot or manually for further processing bug Issue describes a bug done Done but not yet released
Milestone

Comments

@foosel
Copy link
Member

foosel commented May 25, 2022

Problem

  • run setup wizard (or trigger some other mandatory wizard steps to show up)
  • try to skip a mandatory steps by clicking "Next" without filling it in
  • Result: You get a warning that the step is mandatory twice

Solution

Find the reason for that and fix it.

@foosel foosel added bug Issue describes a bug approved Issue has been approved by the bot or manually for further processing labels May 25, 2022
@foosel foosel added this to the 1.9.0 milestone May 25, 2022
@max246
Copy link
Contributor

max246 commented Jun 27, 2022

I have investigated a little bit on this issue, apparently on plugin bootstrapWizard is binding the click event twice in someone to the button NEXT and PREVIOUS.

I am not familar with this plugin but seems like the method "onTabShow" and "onTabChange" is getting called twice as soon as you click the button.

@max246 max246 mentioned this issue Jun 28, 2022
9 tasks
@cp2004 cp2004 linked a pull request Jun 28, 2022 that will close this issue
9 tasks
@cp2004 cp2004 added the pr pending A pull request addressing this has been submitted but not yet merged label Jun 28, 2022
@foosel
Copy link
Member Author

foosel commented Jun 28, 2022

Merged and ready for 1.9.0

@foosel foosel added done Done but not yet released and removed pr pending A pull request addressing this has been submitted but not yet merged labels Jun 28, 2022
@foosel
Copy link
Member Author

foosel commented May 23, 2023

1.9.0 has been released.

@foosel foosel closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Issue has been approved by the bot or manually for further processing bug Issue describes a bug done Done but not yet released
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants