🐛 Fix file upload button properties when SD not enabled #4953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
targets maintenance
4 tasks
|
I've noted the E2E test failures here - will fix on Saturday |
Seemed like a lot of redundant code to just change one class name, so rather than duplicating I've condensed it.
|
Rebased and fixed :) |
foosel
added a commit
that referenced
this pull request
Apr 25, 2024
* 🐛 Fix file upload button properties when SD not enabled Seemed like a lot of redundant code to just change one class name, so rather than duplicating I've condensed it. * 🐛 Fix typo leading to template error --------- Co-authored-by: Gina Häußge <gina@octoprint.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed like a lot of redundant code to just change one class name, so rather than duplicating I've condensed it.
What does this PR do and why is it necessary?
Fixes #4952 and makes future recurrence of the same type of issue unlikely.
How was it tested? How can it be tested by the reviewer?
It has not (yet) been tested, but should be fine. No drastic changes, but I will check it runs tomorrow.
Any background context you want to provide?
#4633
What are the relevant tickets if any?
#4952