Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.10.0] Drag'n'drop upload is broken in Safari #5004

Closed
foosel opened this issue Apr 30, 2024 · 2 comments
Closed

[1.10.0] Drag'n'drop upload is broken in Safari #5004

foosel opened this issue Apr 30, 2024 · 2 comments
Labels
approved Issue has been approved by the bot or manually for further processing bug Issue describes a bug bugfix release relevant Issue should be looked at for backporting into the next bugfix release done Done but not yet released
Milestone
1.10.x

Comments

@foosel
Copy link
Member

foosel commented Apr 30, 2024

The problem

Drag'n'drop file upload doesn't work on Safari because it apparently refuses to populate dataTransfer.items on the drag event, thus making it run into one solution for #4843 and thus not triggering the drag'n'drop overlay.

The solution

Always assume we have files present (even if someone just accidentally dragged a piece of highlighted text) when Safari is detected. If this annoys you, blame Apple.
@foosel foosel added bug Issue describes a bug approved Issue has been approved by the bot or manually for further processing bugfix release relevant Issue should be looked at for backporting into the next bugfix release labels Apr 30, 2024
@foosel foosel added this to the 1.10.x milestone Apr 30, 2024
@foosel
Copy link
Member Author

foosel commented Apr 30, 2024

Fixed and ready for 1.10.1

@foosel foosel added the done Done but not yet released label Apr 30, 2024
@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/drag-and-drop-no-longer-working-after-update/58274/3

@foosel foosel closed this as completed in 6933906 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved Issue has been approved by the bot or manually for further processing bug Issue describes a bug bugfix release relevant Issue should be looked at for backporting into the next bugfix release done Done but not yet released
Projects
OctoPrint Backlog
Status: Done
Milestone
1.10.x
Development

No branches or pull requests
2 participants
@foosel @GitIssueBot