-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
untested: Use same image for :latest :x.y.z :x.y and :x docker tags #100
untested: Use same image for :latest :x.y.z :x.y and :x docker tags #100
Conversation
@morganchristiansson thanks for the PR! I love the idea, but unfortunately it's not future proof. The Adding all the tags to the same build command eliminates the ability to do that. For example, the current file allows us to build Also, very soon we'll have image variants such as We are using a distributed cache ( This idea still has merit though, since perhaps we could write the tag string array to a variable and just use that variable in the final command, so that we can still use the dynamic tag resolution but have all those tags passed to a single command. While I don't think I can accept this pull request as is, it's worth considering how to include your intent in the work I'm doing over the next 2 weeks to create the expanded built system. |
Also, I noticed you caught that typo. In the future, consider splitting those up into separate PR's, since one is a fix, and one is a proposed enhancement. I would have been able to accept the one even if I didn't accept the other. I made the fix myself since I'm doing work on this today and for some of the roadmap stuff I mentioned above, and that fix will be needed. I hate not having you as a contributor since you were the one who caught it. |
Sorry for late reply. And bless - I too have strong feelings about git history :-) Anyhow I was just expecting the docker image id for :latest to match one of the other tagged images and it turns out they are separately built images of same version. Doesn't really matter I guess just something I use to confirm version of :latest. Thought it made sense to build 1 image per GH action run but you're probably right that HackerHappyHour/tagging-strategy is better for you. Was just showing off creating multiple tags for a single image id. |
@morganchristiansson before your pull request I didn't realize i could use multiple tags in buildx. I've started working on docker/metadata-action#18 to allow use of the new official docker actions with this workflow as a result. |
@morganchristiansson thanks largely to your original PR, I've done some great work to improve the builds and remove the matrices, dynamically determining the image tags needed for each build command. While I didn't wind up going with your PR, (I wanted to implement support for new official docker actions), I'd like to call you out in special thanks either in the README or the CHANGELOG (which will be created soon). Is that ok with you? |
Super late reply again :-) Awesome to read. Your reply is enough. Thank you and you're welcome. Yeah multiple tags is awesome. Not sure plain docker build accepts multiple It's a bit of a go-to pattern for me to ctrl-f the image id on docker hub to see what tags are sharing the same image |
I'm a bit of a noob with github actions so not sure how to test this... feedback?