Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt PrintJobHistory plugin #1248

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

dojohnso
Copy link
Contributor

Updated references to point to my fork of the repo for v1.17.1 (previously 1.17.0). The release includes a couple bug fixes people were waiting for, otherwise it's the same.

https://github.com/dojohnso/OctoPrint-PrintJobHistory/releases/tag/1.17.1

Let me know if I missed anything or need to do anything else. Thank you!

Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change necessary, date should remain the same.

_plugins/PrintJobHistory.md Outdated Show resolved Hide resolved
_data/update_check_overlays.yaml Show resolved Hide resolved
_data/notices.yaml Outdated Show resolved Hide resolved
@jneilliii
Copy link
Contributor

Looks like GitHub is having issues right now, so once it catches up and the additional commit(s) show up with these changes we can finalize the adoption.

_data/update_check_overlays.yaml Outdated Show resolved Hide resolved
Copy link
Member

@cp2004 cp2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments resolved, don't want to hold up the process so back over to @jneilliii :)

@jneilliii jneilliii merged commit 823a230 into OctoPrint:gh-pages Nov 27, 2023
4 checks passed
@dojohnso
Copy link
Contributor Author

Thanks again everyone! FYI the abandoned notice still pops up in addition to the update. I'm sure people will figure it out, just wanted to mention it in case it got overlooked. I'm not sure of your process of course so just putting it out there. 🙂

@jneilliii
Copy link
Contributor

Yeah, the notices typically go out quickly, while the software update caches the list of available versions for a day I think. You can always use software update settings and force check for updates to bypass the cache.

image

@dojohnso
Copy link
Contributor Author

Just curious when this abandoned notice and status goes away?
image
image

@jneilliii
Copy link
Contributor

Ah, you didn't remove the abandoned line from the PrintJobHistory.md file. That was my mistake for missing it during review. Will be updated once this PR passes checks and gets merged.

#1249

@dojohnso
Copy link
Contributor Author

Ok sounds good, thank you! I saw that line in there but wasn't sure who managed it so I left it alone. Makes sense and again I appreciate everyone's help getting this moved. I've already had great feedback and interactions with users who are excited to see development pick up on it again. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants