-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt PrintJobHistory plugin #1248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change necessary, date should remain the same.
Looks like GitHub is having issues right now, so once it catches up and the additional commit(s) show up with these changes we can finalize the adoption. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments resolved, don't want to hold up the process so back over to @jneilliii :)
Thanks again everyone! FYI the abandoned notice still pops up in addition to the update. I'm sure people will figure it out, just wanted to mention it in case it got overlooked. I'm not sure of your process of course so just putting it out there. 🙂 |
Ah, you didn't remove the abandoned line from the PrintJobHistory.md file. That was my mistake for missing it during review. Will be updated once this PR passes checks and gets merged. |
Ok sounds good, thank you! I saw that line in there but wasn't sure who managed it so I left it alone. Makes sense and again I appreciate everyone's help getting this moved. I've already had great feedback and interactions with users who are excited to see development pick up on it again. Cheers! |
Updated references to point to my fork of the repo for v1.17.1 (previously 1.17.0). The release includes a couple bug fixes people were waiting for, otherwise it's the same.
https://github.com/dojohnso/OctoPrint-PrintJobHistory/releases/tag/1.17.1
Let me know if I missed anything or need to do anything else. Thank you!