Added plugin hologram #1296
Merged
Added plugin hologram #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ooh...I wonder if your build plate selector is a better option for my bed ready plugin masking selection. I struggled to get it to work but eventually got it and recently noticed alignment issues when reloading the settings in some display resolutions. |
jneilliii
requested changes
May 17, 2024
There was a problem hiding this comment.
one minor change to the listing. in your plugin, you may want to consider replacing your ajax calls with https://docs.octoprint.org/en/master/jsclientlib/base.html#OctoPrintClient.simpleApiCommand in order to avoid any potential CSFR related issues.
jneilliii
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.