Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updated plugin version of Fan Speed Slider Plugin #1298

Merged
merged 2 commits into from
May 31, 2024

Conversation

mival
Copy link
Contributor

@mival mival commented May 28, 2024

No description provided.

Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably include all contributors to authors since this is a fork of a fork and you need to rename the file _plugins/FanSpeedSlider.md to plugins/fanspeedslider.md to match the plugin_identifier.

_plugins/FanSpeedSlider.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed this before @mival but update this URL and one last thing on the plugin's repo. You need to create a release tagged 0.2.3 to match the plugin version identified in setup.py.

_plugins/fanspeedslider.md Show resolved Hide resolved
@mival
Copy link
Contributor Author

mival commented May 31, 2024

@jneilliii and hopefully I created tag for version and also release for that tag.

@jneilliii jneilliii merged commit 551e87a into OctoPrint:gh-pages May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants