Microdata layout for Breadcrumb module #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching the preferences as described here: https://schema.org/BreadcrumbList The user can still add a class to the separator … And Google and co are happy :)
Bucklash
changed the title
| echo '<li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem">'; | ||
| if ( $i < $count -1 ) { // If not the last item in the breadcrumbs add the separator | ||
| if ( !empty($list[$i]->link ) ) { | ||
| echo '<a itemscope itemtype="http://schema.org/Thing" |
There was a problem hiding this comment.
you need to remove
itemscope itemtype="http://schema.org/Thing"
part from a and span elements, otherwise google does not recognize it correctly (it does not read url property)
|
Thanks for your contribution, please see my inline notes for minor corrections that are needed. |
Erroneous code: itemscope itemtype="http://schema.org/Thing" Removed '<wbr>', however, the flow of the list items is now no guaranteed...: With <wbr>: home > blog > my blog items > blog item 1 Without <wbr>: home > blog > my blog items > blog item 1 It now looks like the arrow could be a prefix to the li item, not a suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching the preferences as described here:
https://schema.org/BreadcrumbList
The user can still add a class to the separator …
And Google and co are happy :)