Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if $value is an array before doing the count #754

Merged
merged 1 commit into from Sep 30, 2023
Merged

Check if $value is an array before doing the count #754

merged 1 commit into from Sep 30, 2023

Conversation

olivier-nolbert
Copy link
Contributor

If not, raises an error on PHP 8(.1) website if fieldx is empty

sebastienheraud
sebastienheraud approved these changes Sep 30, 2023
View reviewed changes
Copy link
Member

@sebastienheraud sebastienheraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @olivier-nolbert

@sebastienheraud sebastienheraud merged commit 0325779 into Octopoos:master Sep 30, 2023
sebastienheraud added a commit that referenced this pull request Sep 30, 2023
@sebastienheraud
Merge pull request #754 from Agence-DBCOM/fix-field-x-value-not-array…
94471ce 
…-php8

Check if $value is an array before doing the count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienheraud sebastienheraud sebastienheraud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olivier-nolbert @sebastienheraud