Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default proxy for MSAL authentication #1133

Merged
merged 2 commits into from Sep 25, 2023
Merged

Conversation

mik-ky
Copy link
Contributor

@mik-ky mik-ky commented Sep 21, 2023

Uses a default proxy when authenticating to Azure.

Steps to check whether proxy is being used:

  • Create an ARM template
  • Configure Octopus server to use a custom proxy with your local proxy
  • Verify access logs

ARM deploy
image

Azure webapp (although deployment has failed for different reason)
image

Also cherry-picks a commit which hasn't been applied to release/2023.2 (but has been released as 25.5.9-hotfix3) in order to make sure it's not dropped.

Relates to OctopusDeploy/Issues#8353

@mik-ky mik-ky requested a review from a team September 22, 2023 06:43
@mik-ky mik-ky merged commit f563ac3 into release/2023.2 Sep 25, 2023
24 checks passed
Copy link
Contributor

@tothegills tothegills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Octopus custom proxy and IE proxy.

@mik-ky mik-ky deleted the chrisk/msal-proxy-fix branch September 25, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants