Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceManagementPublishProfileProvider was using the wrong method … #309

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

slewis74
Copy link
Contributor

…overload because AzureAccount.CertificateBytes was a string instead of a byte array. Changed the type so we can't accidentally get it wrong in the future.

Relates to OctopusDeploy/Issues#4798

…overload because AzureAccount.CertificateBytes was a string instead of a byte array. Changed the type so we can't accidentally get it wrong in the future.
Copy link
Contributor

@droyad droyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@slewis74 slewis74 merged commit e70b23b into master Aug 10, 2018
@slewis74 slewis74 deleted the bug-certbytes branch August 10, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants