Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Test Filter and if dot memory tests should be run via command line arguments when running tests via nuke #467

Conversation

nathanwoctopusdeploy
Copy link
Contributor

@nathanwoctopusdeploy nathanwoctopusdeploy commented Aug 22, 2023

Background

This PR allows the test Filter and if the dot memory tests should be run to be set via command line arguments when running tests via nuke

It will allow tests to be split across TeamCity build configurations e.g.

.\build.cmd -target TestWindowsNet48 -TestFilter TestCategory!=PollingOverWebSocket -RunDotMemoryTests true
.\build.cmd -target TestWindowsNet48 -TestFilter TestCategory=PollingOverWebSocket -RunDotMemoryTests false

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@nathanwoctopusdeploy nathanwoctopusdeploy requested a review from a team as a code owner August 22, 2023 11:31
@nathanwoctopusdeploy nathanwoctopusdeploy changed the title Set the Test Filter and if dot memory tests should be run via command line arguments for nuke tests Set the Test Filter and if dot memory tests should be run via command line arguments when running tests via nuke Aug 22, 2023
@nathanwoctopusdeploy
Copy link
Contributor Author

[sc-57387]

@shortcut-integration
Copy link

@nathanwoctopusdeploy nathanwoctopusdeploy merged commit 32bb971 into main Aug 22, 2023
12 of 14 checks passed
@nathanwoctopusdeploy nathanwoctopusdeploy deleted the sast/test-filter-and-dotmemeory-nuke-build-parameters branch August 22, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants