Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package auto-increment pattern ignores correct build numbers #1776

Closed
zentron opened this issue Jul 27, 2015 · 3 comments
Closed

Package auto-increment pattern ignores correct build numbers #1776

zentron opened this issue Jul 27, 2015 · 3 comments
Assignees
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone

Comments

@zentron
Copy link

zentron commented Jul 27, 2015

Background
Assume I have an existing package, 1.2.2 and I create a release via some mechanism (in this example octopack) using the provided package number 1.2.i.
The generated new release will be 1.2.3
Issued again then the release will correctly be 1.2.4.

If however I then request a new release, bumping the major number (2.0.i) the generated version is 2.0.5. This is because it looks like it just uses the build component of the latest generated build regardless of the build number components in the provided pattern. There actually were no 2.0.0-2.0.4

If I also then decide I need to build a release back from the previous major, passing in again 1.2.i It will then generate a build number 1.2.6 (next revision increment from last build of 2.0.5).
Since 2.0.5 > 1.2.6, now no matter how many times I try to create a release using 1.2.i it will always return 1.2.6, meaning only the first time succeeds and all other times will fail saying that it has already been used.

Proposed Solution

  • The auto-increment logic used during release creation needs to take into consideration the version number components of the provided version before deciding what the next incremented number needs to be.
  • This will also require a little more smarts around the DB retrieval of previous versions to ensure the appropriate build numbers are returned and not just the chronologically latest releases.
  • Bumping a major/monor/revision for the first time will require the increment to start again at 0.

Source
http://help.octopusdeploy.com/discussions/questions/5177-auto-increment-release-number

@arex1337
Copy link

Our enterprise is also negatively affected by this bug

@Damovisa Damovisa added the kind/bug This issue represents a verified problem we are committed to solving label Jul 28, 2015
@Damovisa Damovisa assigned Damovisa and unassigned Damovisa Jul 28, 2015
@Damovisa Damovisa added kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time and removed kind/bug This issue represents a verified problem we are committed to solving labels Jul 28, 2015
@zentron zentron self-assigned this Aug 3, 2015
@zentron zentron added in progress and removed ready labels Aug 3, 2015
@PaulStovell PaulStovell added this to the 3.0.11 milestone Aug 6, 2015
@michaelnoonan
Copy link
Contributor

Release Note: Improved the Release version auto-increment logic

@lock
Copy link

lock bot commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

5 participants