Improve messages stored in error variables

[MJRichardson]

The values stored in Octopus.Deployment.Error and Octopus.Deployment.ErrorDetail (and their Step scoped versions) could be more useful.

Currently 'One or more child activities failed.' is being stored in Octopus.Deployment.Error, and Octopus.Deployment.ErrorDetail contains something along the lines of

Octopus.Shared.Tasks.ActivityFailedException: One or more child activities failed.
   at Octopus.Shared.Tasks.ParallelWorkOrder`1.AssertAllCompletedTasksThusFarAreSuccessful() in y:\work\refs\heads\master\source\Octopus.Shared\Tasks\ParallelWorkOrder.cs:line 78
   at Octopus.Shared.Tasks.ParallelWorkOrder`1.Execute() in y:\work\refs\heads\master\source\Octopus.Shared\Tasks\ParallelWorkOrder.cs:line 33
   at Octopus.Shared.Tasks.OctoParallel.ForEach[T](IEnumerable`1 workItems, Nullable`1 maxParallelism, Action`1 executeCallback, CancellationToken cancellation) in y:\work\refs\heads\master\source\Octopus.Shared\Tasks\OctoParallel.cs:line 20
   at Octopus.Server.Orchestration.Deploy.DeploymentTaskController.DistributeStepAcrossMachines(PlannedStep step) in y:\work\refs\heads\master\source\Octopus.Server\Orchestration\Deploy\DeploymentTaskController.cs:line 174
   at Octopus.Server.Orchestration.Deploy.DeploymentTaskController.DispatchStep(PlannedStep step) in y:\work\refs\heads\master\source\Octopus.Server\Orchestration\Deploy\DeploymentTaskController.cs:line 76

[MJRichardson]

Please update http://help.octopusdeploy.com/discussions/problems/37083-error-and-errordetail-do-not-show-the-correct-information when implemented.

[Irrational86]

@DamianMac Does this mean that this won't be done?

[robpearson]

Found another instance of this issue. Re-opening the issue.

Source: http://help.octopusdeploy.com/discussions/problems/45082

[vanessalove]

thought this was done here: #2216
but customer is on 3.3+

[robpearson]

@vanessalove This is a slightly different bug/error. This occurs when the steps are executed in parallel and it's a diff code path.

[markryd]

I'll fix things so the error contains the Step name and Machine name when a parallel task fails rather than just "A child task failed", but we are still going to end up with "The remote script failed with exit code 1" in the case of failing powershell steps since that is the error octopus sees. We never see the actual powershell error. We could potentially suck out the StdErr output and if we wanted.

[octoreleasebot]

Release Note: Octopus.Deployment.Error now contains better information if a parallel step fails

[JesseNaranjo]

@markryd Thanks so much for implementing this!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.