Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new variable to project with limited permissions to scopes deletes variables not in scope #2206

Closed
hnrkndrssn opened this issue Dec 2, 2015 · 4 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@hnrkndrssn
Copy link

Repro:

  • Create a new project
  • Add two variables, VarDev & VarProd, scoped to dev and prod environments respectively
  • As a DEV user, view the variables-- as expected we only see the VarDev variable
  • As a DEV user, try to add VarNew variable-- as expected we get permission denied
  • As an ADMIN user, grant the DEV user permissions to edit variables
  • As a DEV user, try to save new variables again-- as expected we are now allowed.

Expected result: VarDev, VarProd, and VarNew variables should be present.

Actual result: VarDev and VarNew are present, while VarProd has been "deleted"

Source: http://help.octopusdeploy.com/discussions/problems/42649

@hnrkndrssn hnrkndrssn added the kind/bug This issue represents a verified problem we are committed to solving label Dec 2, 2015
@robpearson robpearson self-assigned this Dec 9, 2015
@robpearson
Copy link

Failed to reproduce but customer has provided more detail including:

  • additional steps/detail to reproduce
  • audit log screenshot

Needs further investigation.

@zentron
Copy link

zentron commented Jan 3, 2016

https://github.com/OctopusDeploy/OctopusDeploy/commit/1d3ebafbae2be2dcf3f3fd2ad482cec342464963
If the user's available environments changes while they are editing the variable set they will be prompted to reload the page. This is the same existing mechanism that is used currently if someone else has changed the variable set while the user makes changes.

@zentron zentron closed this as completed Jan 3, 2016
@zentron zentron added this to the 3.2.14 milestone Jan 3, 2016
@zentron
Copy link

zentron commented Jan 3, 2016

Release Note: Updating project variables while the user's environment permissions have changed forces user to reload. This blocks a bug causing variables to be removed.

@lock
Copy link

lock bot commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

4 participants