Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message when a folder is specified as JSON config file #2354

Closed
tothegills opened this issue Feb 8, 2016 · 2 comments
Closed

Improve the error message when a folder is specified as JSON config file #2354

tothegills opened this issue Feb 8, 2016 · 2 comments
Assignees
@tothegills
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone
3.3.0-beta0002

Comments

@tothegills
Copy link
Contributor

When using the JSON config feature and a folder is specified as the path to the JSON config file to create, a misleading error message is presented:

System.UnauthorizedAccessException: Access to the path 'C:\Octopus\TestInstance1\Applications\The Environment\App\0.1.72\approot' is denied.

We could check if the target is a folder and present a more suitable error message instead.
@tothegills tothegills added this to the 3.3.0-beta.2 milestone Feb 8, 2016
@tothegills tothegills added kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time ready labels Feb 8, 2016
@tothegills tothegills changed the title Improve the error message when a folder is specified as JSON config path Improve the error message when a folder is specified as JSON config file Feb 8, 2016
@tothegills tothegills self-assigned this Feb 8, 2016
tothegills added a commit to OctopusDeploy/Calamari that referenced this issue Feb 8, 2016
@tothegills
Display a helpful error when JSON config being applied to a folder.
9d35782 
Fixes OctopusDeploy/Issues#2354
@tothegills tothegills mentioned this issue Feb 8, 2016
Merged
@octoreleasebot
Copy link

Release Note: Improve the error message when using the JSON config feature and a folder is specified as the target file

@lock
Copy link

lock bot commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tothegills tothegills

Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Milestone
3.3.0-beta0002
Development

No branches or pull requests
3 participants
@tothegills @michaelnoonan @octoreleasebot