Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading a zip package with a dash as name / version delimiter returns error #3042

Closed
hnrkndrssn opened this issue Jan 3, 2017 · 6 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving

Comments

@hnrkndrssn
Copy link

E.g. product-1.0.1.zip fails with the error message The resource was not found on this server, as the package will be parsed as packageId product-1 and version 0.1.

@hnrkndrssn hnrkndrssn added the kind/bug This issue represents a verified problem we are committed to solving label Jan 3, 2017
@hnrkndrssn hnrkndrssn changed the title Uploading a zip package with a dash as name version delimiter returns error Uploading a zip package with a dash as name / version delimiter returns error Jan 3, 2017
@droyad
Copy link
Contributor

droyad commented Feb 13, 2017

The parsing is correct, we just need to fix the retrieval of it (see #3076 for more info)

@droyad
Copy link
Contributor

droyad commented Apr 24, 2017

@RachelAmbler
Copy link

@droyad I'm on here as well so can keep an eye on the situation (53874 was my ticket if others were wondering).

@droyad
Copy link
Contributor

droyad commented Apr 28, 2017

When we create package related URLs, we combine the package id with the version using a -. eg id MyPackage-1 and version 1.0.0 becomes MyPackage-1-1.0.0. When parsing the url, the code can't figure out if the version is 1.0.0 or 1-1.0.0 as they are both valid SemVer2 versions.

The fix is to use . to separate the id and version as this is consistent with nuget package naming or split it into two parameters.

@droyad
Copy link
Contributor

droyad commented Sep 27, 2017

This has been fixed sometime between 3.13.2 and 3.17.2.

@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants