The IndexResponseDescriptor is issuing unbounded SQL queries

[michaelnoonan]

See this line of code: https://github.com/OctopusDeploy/OctopusDeploy/blob/master/source/Octopus.Server/Web/Infrastructure/Api/IndexResponseDescriptor.cs#L48

It seems to have crept in by accident, but it was causing every API request which used the IndexResponseDescriptor to issue a single unbounded query, and then issue the bounded query afterwards. This really becomes obvious on installations with lots of releases etc.

For example: when we call /api/releases we are executing SELECT * FROM dbo.[Release] ORDER BY [Id] and then we issue the paginated query:
2017-05-12 08:00:36.8727 56 INFO Reader took 2672ms (2ms until the first record) in transaction 'http://localhost/api/releases 210f59c8b58a4ebe857d2a198853c37f': SELECT * FROM dbo.[Release] ORDER BY [Id]

It's not common that we use these APIs, but this code is obviously misbehaving.

See original conversation: https://octopusdeploy.slack.com/archives/C4LB9LZNK/p1494541044882046

[octoreleasebot]

Release Note: Fixed a performance problem where both an unbounded and paginated SQL query were issued for some requests

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.