Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script modules written with incorrect encoding #3873

Closed
hnrkndrssn opened this issue Oct 19, 2017 · 2 comments
Closed

Script modules written with incorrect encoding #3873

hnrkndrssn opened this issue Oct 19, 2017 · 2 comments
Assignees
Labels
feature/calamari kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@hnrkndrssn
Copy link

The change in OctopusDeploy/Calamari@0c1e431 causes particular characters (i.e. ) to be written incorrectly to file. Using the CalamariFileSystem.OverwriteFile(string, string, Encoding) overload to use Encoding.UTF8 fixes the problem.

Source: https://help.octopusdeploy.com/discussions/problems/60747-upgrade-from-3175-to-3176-changed-content-in-script-module

@hnrkndrssn hnrkndrssn self-assigned this Oct 19, 2017
@hnrkndrssn hnrkndrssn added area/execution kind/bug This issue represents a verified problem we are committed to solving feature/calamari labels Oct 19, 2017
@tothegills tothegills added this to the 3.17.8 milestone Oct 19, 2017
@tothegills
Copy link
Contributor

tothegills commented Oct 19, 2017

Release note: Fixed an exception loading script modules containing certain characters

@tothegills tothegills assigned tothegills and unassigned hnrkndrssn Oct 19, 2017
@lock
Copy link

lock bot commented Nov 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/calamari kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

2 participants