Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert certificate generation change #410

Closed
PaulStovell opened this issue Dec 25, 2013 · 2 comments
Closed

Revert certificate generation change #410

PaulStovell opened this issue Dec 25, 2013 · 2 comments
Labels
kind/bug This issue represents a verified problem we are committed to solving

Comments

@PaulStovell
Copy link
Member

In OctopusDeploy/OctopusDeploy@6ac704ff8553d8ec009649f4a48dd6ca50b24149 I tried to fix the issue with certificate generation when a profile isn't loaded. Unfortunately it caused a different error on a customer machine:

System.IO.FileNotFoundException: Could not load file or assembly 'Octopus.Shared.XmlSerializers' or one of its dependencies. The system cannot find the file specified.
File name: 'Octopus.Shared.XmlSerializers'
   at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
   at System.Reflection.RuntimeAssembly.LoadWithPartialNameInternal(AssemblyName an, Evidence securityEvidence, StackCrawlMark& stackMark)
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHRInternal(Int32 errorCode, IntPtr errorInfo)
   at Octopus.Shared.Internals.CertificateGeneration.CryptContext.GenerateKeyExchangeKey(Boolean exportable, Int32 keyBitLength) in c:\TeamCity\buildAgent\work\1116bd9da9e239fd\source\Octopus.Shared\Internals\CertificateGeneration\CryptContext.cs:line 97
  at Octopus.Shared.Internals.CertificateGeneration.CryptContext.CreateSelfSignedCertificate(SelfSignedCertProperties properties) in c:\TeamCity\buildAgent\work\1116bd9da9e239fd\source\Octopus.Shared\Internals\CertificateGeneration\CryptContext.cs:line 50
   at Octopus.Shared.Security.CertificateGenerator.Generate(String fullName, Boolean exportable) in c:\TeamCity\buildAgent\work\1116bd9da9e239fd\source\Octopus.Shared\Security\CertificateGenerator.cs:line 27

I think this is a case of the wrong exception being thrown but the certificate still cannot be generated. The customer reverted back to 2.0.5 and was able to generate certificates without problems. Let's revert the change and find another way to deal with the profile problem.

@PaulStovell
Copy link
Member Author

Related to: #353

@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

2 participants