Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard crashes when invalid release number found #4888

Closed
1 task done
BobJWalker opened this issue Sep 11, 2018 · 3 comments
Closed
1 task done

Dashboard crashes when invalid release number found #4888

BobJWalker opened this issue Sep 11, 2018 · 3 comments
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@BobJWalker
Copy link

Are you a customer of Octopus Deploy? Don't raise the issue here. Please contact our support team so we can triage your issue, making sure it's handled appropriately.

Prerequisites

  • [x ] I have verified the problem exists in the latest version
  • [ x] I have searched open and closed issues to make sure it isn't already reported
  • [ x] I have written a descriptive issue title
  • [ x] I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

From support email:

Octopus Version: 2018.7.13

I had mistakenly set a project release version template to:

#{Octopus.Date.Year}.#{Octopus.Date.Month}.#{Octopus.Date.Day}.#{Octopus.Date.Hour}

Instead of:

#{Octopus.Date.Year}.#{Octopus.Date.Month}.#{Octopus.Date.Day}.#{Octopus.Time.Hour}

I also had a scheduled trigger that creates a release (not sure what happens if you create the release manually). When it triggered, it looked like it did start deploying to tenants, but the release was named "2018.09.10.#{Octopus.Date.Hour}".This blew up the dashboard with an error about parsing the variables. I also could not manually get into the release to delete it, with a similar error.

As a quick workaround, I had to go into SQL and manually edit the release name and then restart the Octopus service to get back in.

What I expected to happen

When an invalid replacement (Octopus.Date.Hour) is found don't crash the dashboard.

Steps to reproduce

Set the release version template to #{Octopus.Date.Year}.#{Octopus.Date.Month}.#{Octopus.Date.Day}.#{Octopus.Date.Hour} and manually create the release.

@BobJWalker BobJWalker added kind/bug This issue represents a verified problem we are committed to solving area/modelling labels Sep 11, 2018
@Flamage82 Flamage82 self-assigned this Sep 11, 2018
@Flamage82
Copy link

@octoreleasebot octoreleasebot added this to the 2018.8.5 milestone Sep 17, 2018
@octoreleasebot
Copy link

Release Note: Fixed a bug where triggers could create releases with invalid versions.

@lock
Copy link

lock bot commented Dec 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot unassigned Flamage82 Dec 16, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

3 participants