Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator doesn't gracefully handle project triggers with an environment filter #5084

Closed
michaelnoonan opened this issue Nov 13, 2018 · 3 comments
Assignees
Labels
feature/migrator kind/bug This issue represents a verified problem we are committed to solving size/tiny ~1 hour
Milestone

Comments

@michaelnoonan
Copy link
Contributor

michaelnoonan commented Nov 13, 2018

Imagine you have an project trigger which is filtered so it only applies for events from certain environments, like Dev and Test. If you export a project which can only be deployed to Test but not Dev, the Dev environment won't be exported since it's not necessary for that project. Now when you import the project, it will fail when importing the project trigger because there is no such environment as Dev in the target.

What I expected to happen

When importing a project trigger which is restricted to certain environments, if any of those environments do not exist in the target, remove the restriction instead of failing the import.

Most other places follow this logic. Following suit will make this scenario behave similarly.

Affected versions

Octopus Server: 3.5 until fixed.

Workarounds

Nothing good:

  1. Only perform full exports and imports.
  2. Avoid using events from unrelated environments to trigger deployments to different environments.
@michaelnoonan michaelnoonan added kind/bug This issue represents a verified problem we are committed to solving feature/migrator size/tiny ~1 hour labels Nov 13, 2018
@michaelnoonan michaelnoonan self-assigned this Nov 13, 2018
@michaelnoonan
Copy link
Contributor Author

@octoreleasebot octoreleasebot added this to the 2018.9.10 milestone Nov 14, 2018
@octoreleasebot
Copy link

Release Note: migrator.exe now correctly handles importing project triggers which filter events for certain environments where some of those environments do not exist in the target

@lock
Copy link

lock bot commented Feb 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/migrator kind/bug This issue represents a verified problem we are committed to solving size/tiny ~1 hour
Projects
None yet
Development

No branches or pull requests

2 participants