Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from version prior to 2019.1 can corrupt `builtinrepositoryconfigurations-single` configuration json column #5338

Closed
johnsimons opened this issue Feb 26, 2019 · 2 comments

Comments

@johnsimons
Copy link

commented Feb 26, 2019

Are you a customer of Octopus Deploy? Don't raise the issue here. Please contact our support team so we can triage your issue, making sure it's handled appropriately.

Prerequisites

  • I have verified the problem exists in the latest version
  • I have searched open and closed issues to make sure it isn't already reported
  • I have written a descriptive issue title
  • I have linked the original source of this report
  • I have tagged the issue appropriately (area/*, kind/bug, tag/regression?)

The bug

Access to /library/builtinrepository thrown an exception

Octopus v2019.1.10

An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = BuiltInFeedStatsResponder (DelegateActivator), Services = [Octopus.Server.Web.Api.NuGet.BuiltInFeedStatsResponder], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = None, Ownership = ExternallyOwned ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = BuiltInFeedStatsResponder (ReflectionActivator), Services = [Octopus.Server.Web.Api.NuGet.BuiltInFeedStatsResponder], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = None, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = BuiltInPackageRepository (DelegateActivator), Services = [Octopus.Core.BuiltInFeed.IBuiltInPackageRepository], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = None, Ownership = ExternallyOwned ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = BuiltInPackageRepository (ReflectionActivator), Services = [Octopus.Core.BuiltInFeed.BuiltInPackageRepository, Octopus.Core.BuiltInFeed.IBuiltInPackageRepository], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An exception was thrown while invoking the constructor 'Void .ctor(Octopus.Shared.Util.IOctopusFileSystem, Octopus.Core.RelationalStorage.IOctopusRelationalStore, Octopus.Core.BuiltInFeed.IBuiltInRepositoryConfigurationStore, Octopus.Core.Model.Events.IEventStore)' on type 'BuiltInPackageRepository'. ---> Unexpected character encountered while parsing value: @. Path '', line 0, position 0. (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.)

Autofac.Core.DependencyResolutionException

at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)

at Autofac.Core.Resolving.InstanceLookup.Execute()

at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)

at Autofac.Core.Resolving.ResolveOperation.Execute(IComponentRegistration registration, IEnumerable`1 parameters)

at Autofac.ResolutionExtensions.TryResolveService(IComponentContext context, Service service, IEnumerable`1 parameters, Object& instance)

at Autofac.ResolutionExtensions.ResolveService(IComponentContext context, Service service, IEnumerable`1 parameters)

at Octopus.Server.Web.Infrastructure.OctopusNancyModule.<>c__DisplayClass14_0.<get_Routes>b__1(Object x)

at Nancy.Routing.Route.<>c__DisplayClass4.<Wrap>b__3(Object parameters, CancellationToken context)


--Inner Exception--

It seems in older versions the PackagesDirectory was stored as a fully qualified path.

What I expected to happen

It should list the built in packages

Steps to reproduce

  1. Upgrade from a previous version, eg 3.17.12

Screen capture

image

Affected versions

v2019.1+

Octopus Server:

Workarounds

update [Configuration] setJSON='{"PackagesDirectory":"Packages"}'
WHERE Id ='builtinrepositoryconfigurations-single'

Links

https://secure.helpscout.net/conversation/787440212/39901/

@johnsimons johnsimons added the kind/bug label Feb 26, 2019
@johnsimons johnsimons closed this Feb 27, 2019
@johnsimons johnsimons added this to the 2019.1.12 milestone Feb 27, 2019
@johnsimons johnsimons self-assigned this Feb 27, 2019
@johnsimons

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

Release Note: Corrupt builtinrepositoryconfigurations-single configuration json column fixed

@johnsimons johnsimons modified the milestones: 2019.1.12, 2019.2.1 Feb 28, 2019
@lock

This comment has been minimized.

Copy link

commented May 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.