Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic to determine if service fabric upgrades are enabled does not evaluate correctly #5657

Closed
tothegills opened this issue Jul 2, 2019 · 2 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving
Milestone

Comments

@tothegills
Copy link
Contributor

See https://help.octopus.com/t/urgent-calamari-upgrade-has-broken-service-fabric-upgrade/23416

Specifically, line 126:
$UpgradeEnabled = $UpgradeEnabledInProfile -and -not $OverrideUpgradeBehavior -eq ‘VetoUpgrade’

This doesn’t evaluate properly - you can check quickly in PowerShell as follows:
e.g.

$UpgradeEnabledInProfile = $true
$OverrideUpgradeBehavior = ‘None’
$UpgradeEnabled = $UpgradeEnabledInProfile -and -not $OverrideUpgradeBehavior -eq ‘VetoUpgrade’
@tothegills tothegills added the kind/bug This issue represents a verified problem we are committed to solving label Jul 2, 2019
@tothegills tothegills self-assigned this Jul 2, 2019
tothegills added a commit to OctopusDeploy/Calamari that referenced this issue Jul 2, 2019
tothegills added a commit to OctopusDeploy/Calamari that referenced this issue Jul 2, 2019
@tothegills tothegills added this to the 2019.7.0 milestone Jul 2, 2019
@tothegills
Copy link
Contributor Author

Release note: Fixed the logic in Azure Service Fabric deployments to determine if upgrades are available

@lock
Copy link

lock bot commented Sep 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

1 participant