Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory elevation #6721

Closed
5 tasks done
matt-richardson opened this issue Jan 5, 2021 · 1 comment
Closed
5 tasks done

Remove mandatory elevation #6721

matt-richardson opened this issue Jan 5, 2021 · 1 comment
Assignees
Labels
area/security feature/usability kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Milestone

Comments

@matt-richardson
Copy link
Contributor

The enhancement

What is the problem this solves or benefit it gives

On Windows, we currently use an application manifest to demand admin rights to run the octopus.server.exe application.
This is too broad, actively encouraging bad behaviour at runtime for customers (violating the principal of least privilege) and also at dev time (running IDEs as admin etc).
This forces you to run an admin shell to even run octopus.server.exe --help!
This also blocks potential future functionality like command line auto-complete.

image
(well, this is an unsigned binary... users would see a slightly different one because its signed)

Proposed solution

Instead of relying on a manifest to ask for admin rights, we should just show a message when the user is trying to do something that requires admin but doesn't have admin rights.

The commands this will impact are:

  • builtin-worker (windows only)
  • checkservices (windows only)
  • service
  • ssl-certificate
  • watchdog (windows only)
  • run

All others should work without admin rights.

Workarounds

None, unfortunately. The application must run with admin rights.

Links

Prerequisites

  • I have searched open and closed issues to make sure it isn't already requested
  • I have discussed this in #feature-discussion or #backlog and the consensus is that this is something we plan on adding in the near future
  • I have written a descriptive issue title
  • I have linked the original source of this feature request
  • I have tagged the issue appropriately (area/*, kind/enhancement)
@matt-richardson matt-richardson added kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time feature/usability area/security labels Jan 5, 2021
@matt-richardson matt-richardson self-assigned this Jan 5, 2021
@octoreleasebot octoreleasebot added this to the 2021.1.0 milestone Jan 5, 2021
@octoreleasebot
Copy link

octoreleasebot commented Jan 5, 2021

Release Note: Local Administrator permissions are no longer required for most Octopus.Server commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security feature/usability kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

2 participants