Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure App Service step errors if no connection strings supplied and app settings are supplied #6891

Closed
MJRichardson opened this issue May 23, 2021 · 1 comment
Assignees
Labels
area/steps feature/azure kind/bug This issue represents a verified problem we are committed to solving

Comments

@MJRichardson
Copy link

The Deploy an Azure App Service step in will throw an error if app settings are specified, but no connection strings are.

Reported in 2021.1.7149
Reported by (private link)

image

Value cannot be null. (Parameter 'key')
System.ArgumentNullException
at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
at System.Collections.Generic.Dictionary`2.set_Item(TKey key, TValue value)
at Calamari.AzureAppService.Behaviors.AzureAppServiceSettingsBehaviour.PublishAppSettings(WebSiteManagementClient webAppClient, TargetSite targetSite, AppSetting[] appSettings, String authToken)
at Calamari.AzureAppService.Behaviors.AzureAppServiceSettingsBehaviour.Execute(RunningDeployment context)
at Calamari.Common.Plumbing.Pipeline.PipelineCommand.ExecuteBehaviour(RunningDeployment context, IBehaviour behaviour)
at Calamari.Common.Plumbing.Pipeline.PipelineCommand.Execute(ILifetimeScope lifetimeScope, IVariables variables)
@MJRichardson MJRichardson added the kind/bug This issue represents a verified problem we are committed to solving label May 23, 2021
MJRichardson added a commit to OctopusDeploy/Sashimi.AzureAppService that referenced this issue May 23, 2021
MJRichardson added a commit to OctopusDeploy/Sashimi.AzureAppService that referenced this issue May 24, 2021
MJRichardson added a commit to OctopusDeploy/Sashimi.AzureAppService that referenced this issue May 24, 2021
MJRichardson added a commit to OctopusDeploy/Sashimi.AzureAppService that referenced this issue May 24, 2021
@Octobob
Copy link
Member

Octobob commented Aug 11, 2021

🎉 The fix for this issue has been released in:

Release stream Release
2021.1 2021.1.7202
2021.2 2021.2.4057
2021.3+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/steps feature/azure kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

4 participants