Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to fully validate variables #808

Closed
nblumhardt opened this issue Mar 26, 2014 · 3 comments
Closed

Option to fully validate variables #808

nblumhardt opened this issue Mar 26, 2014 · 3 comments
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time

Comments

@nblumhardt
Copy link
Contributor

Once, using an undefined variable like #{Fooo} would cause an error. On moving to 2.0, since we now use partially-evaluated variables in many more places, this is no longer an error - which for users is less convenient than the old fail-fast approach was: http://help.octopusdeploy.com/discussions/questions/2077-variables-in-the-process-that-dont-exist-in-the-scope

The root issue here is that the original variable evaluator works on a set at a time.

Variable evaluation should be completely lazy/dynamic, so that undefined variables are fine so long as they're not used, but if used they throw.

@nblumhardt nblumhardt added this to the 2.x Backlog milestone Mar 26, 2014
@PaulStovell PaulStovell removed this from the 2.x Backlog milestone Apr 5, 2014
@PaulStovell
Copy link
Member

Closing this - agree we should do it when we do #778 (no need to keep both items open)

@nblumhardt
Copy link
Contributor Author

Reopening so that we can make these changes in a fine-grained way rather than via one huge ticket.

@nblumhardt nblumhardt reopened this Aug 15, 2014
@nblumhardt nblumhardt added this to the 2.6 milestone Aug 15, 2014
@hnrkndrssn hnrkndrssn modified the milestone: 2.6 Sep 10, 2014
@lock
Copy link

lock bot commented Nov 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement This issue represents an enhancement we are committed to adding to Octopus as some time
Projects
None yet
Development

No branches or pull requests

3 participants