Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycles - Phases Reorder function not working as expected when reorder newly added phases #8691

Closed
HuyPhanNguyen opened this issue Mar 18, 2024 · 4 comments
Assignees
Labels
kind/bug This issue represents a verified problem we are committed to solving

Comments

@HuyPhanNguyen
Copy link

HuyPhanNguyen commented Mar 18, 2024

Severity

Confuse user when they try to reorder phases.

Version

2024.2

Latest Version

I could reproduce the problem in the latest build.

What happened?

The phases in "Reorder Phases" multiply itself.
image

Got error screen if try to click "Reorder Phase" again.
image

Reproduction

  1. Create a lifecycle with 2 phases (Phase 1, Phase 2) and hit save.
  2. Edit that lifecycle and add another 2 phases (Phase 3 or Phase 4) but don't click "Save" button but click "Reorder Phases".
  3. Try drag the newly add Phases - Phase 4 over Phase 3 then drag Phase 4 over Phase 2.
  4. Result in the "Phase 4" multiple itself.

Error and Stacktrace

Error: Cannot have two MultiBackends at the same time.
    at E.setup (MultiBackendImpl.js:122:15)
    at handleRefCountChange (DragDropManagerImpl.js:21:25)
    at Object.d [as dispatch] (redux.js:296:32)
    at e.value (HandlerRegistryImpl.js:92:18)
    at o (registration.js:10:27)
    at O.value (decorateHandler.js:149:32)
    at O.value (decorateHandler.js:134:14)
    at O.value (decorateHandler.js:110:14)
    at cl (react-dom.production.min.js:212:132)
    at Ts (react-dom.production.min.js:255:229)

More Information

No response

Workaround

  • Save the lifecycles before re-ordering
@HuyPhanNguyen HuyPhanNguyen added the kind/bug This issue represents a verified problem we are committed to solving label Mar 18, 2024
@LewisJohnsonOctopus
Copy link

We have tested this in other areas - Looks like the reordering is causing the same fault in runbooks, deployment processes and the reordering of environments.

During our testing we found that saving the runbooks/deployment process before reordering had no affect and the fault persisted. This also now seems to be the case for lifecycles post saving.

@LewisJohnsonOctopus
Copy link

Another customer experiencing this issue (internal) - https://octopus.zendesk.com/agent/tickets/176337

@shaunmarx
Copy link

Release Note: Fixed an issue where reordering list items in some situations would be duplicated and potentially crashing the ui

@Octobob
Copy link
Member

Octobob commented May 16, 2024

🎉 The fix for this issue has been released in:

Release stream Release
2024.2 2024.2.4331
2024.3+ all releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This issue represents a verified problem we are committed to solving
Projects
None yet
Development

No branches or pull requests

5 participants