Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step template to deploy SSRS reports #150

Merged
merged 2 commits into from
May 25, 2015
Merged

Step template to deploy SSRS reports #150

merged 2 commits into from
May 25, 2015

Conversation

twerthi
Copy link
Contributor

@twerthi twerthi commented Apr 28, 2015

Uploads Sql Server Reporting Services reports from a NuGet package to
SSRS instance.

Uploads Sql Server Reporting Services reports from a NuGet package to
SSRS instance.
@hnrkndrssn hnrkndrssn added this to the vNext milestone Apr 29, 2015
@hnrkndrssn hnrkndrssn self-assigned this Apr 29, 2015
@hnrkndrssn
Copy link
Contributor

LGTM, just one minor thing, could you please rename the file to ssrs-deploy-from-package.json to keep in line with our naming scheme of {service}{action}

Thanks!

@twerthi
Copy link
Contributor Author

twerthi commented Apr 30, 2015

Certainly! My apologies, I’m not familiar with LGTM, what does that mean?

From: Henrik Andersson [mailto:notifications@github.com]
Sent: Wednesday, April 29, 2015 6:13 PM
To: OctopusDeploy/Library
Cc: Sesna, Shawn (DEL)
Subject: Re: [Library] Step template to deploy SSRS reports (#150)

LGTM, just one minor thing, could you please rename the file to ssrs-deploy-from-package.json to keep in line with our naming scheme of {service}{action}

Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/150#issuecomment-97625084.

@twerthi
Copy link
Contributor Author

twerthi commented May 7, 2015

The rename has been completed.

@hnrkndrssn
Copy link
Contributor

LGTM = Looks Good To Me 😄

@twerthi
Copy link
Contributor Author

twerthi commented May 11, 2015

Oh! Okay ☺ New to GitHub, not used to the lingo just yet. PR threw me for a loop too :P

From: Henrik Andersson [mailto:notifications@github.com]
Sent: Monday, May 11, 2015 1:07 PM
To: OctopusDeploy/Library
Cc: Sesna, Shawn (DEL)
Subject: Re: [Library] Step template to deploy SSRS reports (#150)

LGTM = Looks Good To Me [:smile:]


Reply to this email directly or view it on GitHubhttps://github.com//pull/150#issuecomment-101032852.

hnrkndrssn added a commit that referenced this pull request May 25, 2015
Step template to deploy SSRS reports
@hnrkndrssn hnrkndrssn merged commit b1707a6 into OctopusDeploy:master May 25, 2015
@hnrkndrssn hnrkndrssn removed their assignment May 26, 2015
@hnrkndrssn hnrkndrssn modified the milestone: vNext Jun 1, 2015
@vanessalove
Copy link
Contributor

@twerthi
Hi Shawn,

We have had a support request come in about this PR. Not having SSRS installed anywhere we are unable to assist. Is it something you can help or provide guidance with? http://help.octopusdeploy.com/discussions/problems/35429

Vanessa

@twerthi
Copy link
Contributor Author

twerthi commented Jun 30, 2015

Hi Vanessa! I’m trying to take a look, I created an account, but it would appear that it doesn’t have access to that particular discussion.

From: Vanessa [mailto:notifications@github.com]
Sent: Monday, June 29, 2015 5:03 PM
To: OctopusDeploy/Library
Cc: Sesna, Shawn (DEL)
Subject: Re: [Library] Step template to deploy SSRS reports (#150)

@twerthihttps://github.com/twerthi
Hi Shawn,

We have had a support request come in about this PR. Not having SSRS installed anywhere we are unable to assist. Is it something you can help or provide guidance with? http://help.octopusdeploy.com/discussions/problems/35429

Vanessa


Reply to this email directly or view it on GitHubhttps://github.com//pull/150#issuecomment-116883358.

@vanessalove
Copy link
Contributor

Hi Shawn,
I have added you as a participant. Thanks for your help!

@twerthi
Copy link
Contributor Author

twerthi commented Jun 30, 2015

I’m in! Thanks! I will see if I can help, initial look shows what looks to be a false positive when the user says it was successful. Overloaded at work, but I will try to make sure to respond as quickly as I can.

From: Vanessa [mailto:notifications@github.com]
Sent: Monday, June 29, 2015 5:20 PM
To: OctopusDeploy/Library
Cc: Sesna, Shawn (DEL)
Subject: Re: [Library] Step template to deploy SSRS reports (#150)

Hi Shawn,
I have added you as a participant. Thanks for your help!


Reply to this email directly or view it on GitHubhttps://github.com//pull/150#issuecomment-116885592.

@vanessalove
Copy link
Contributor

We really appreciate your help thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants