Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force TLS 1.2 for app insights step template #902

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

harrisonmeister
Copy link
Contributor

@harrisonmeister harrisonmeister commented Apr 11, 2020

Change to Application Insights - Annotate Release step template to force TLS 1.2

Fixes #844

Step template checklist

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

@harrisonmeister
Copy link
Contributor Author

Not ready to merge yet

@harrisonmeister harrisonmeister marked this pull request as ready for review April 14, 2020 18:56
@harrisonmeister
Copy link
Contributor Author

@ryanrousseau - updated to use the graceful method as discussed 👍

Copy link
Contributor

@ryanrousseau ryanrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanrousseau ryanrousseau merged commit 65487b2 into master Apr 15, 2020
@ryanrousseau ryanrousseau deleted the app-insights-tls12 branch April 15, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest App Insights: Annotate Release Failing
2 participants