Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about sensitive step properties on import #56

Closed

Conversation

kpitt
Copy link
Contributor

@kpitt kpitt commented Mar 16, 2015

We already have warnings when importing sensitive variables so the
user knows that the actual values were not imported. We need
similar warnings for deployment process steps because it's easy to
miss sensitive settings such as a custom service user password.

Unlike variables, the UI only shows a descriptive label for the
step properties, so the actual property name would not be useful
in the log message. There are also properties that may not be
used depending on the values of other related properties, so they
don't really need to be set. Instead, just log a general warning
for each step that contains sensitive properties so that the
user knows to check those steps after the import is complete.

We already have warnings when importing sensitive variables so the
user knows that the actual values were not imported.  We need
similar warnings for deployment process steps because it's easy to
miss sensitive settings such as a custom service user password.

Unlike variables, the UI only shows a descriptive label for the
step properties, so the actual property name would not be useful
in the log message.  There are also properties that may not be
used depending on the values of other related properties, so they
don't really need to be set.  Instead, just log a general warning
for each step that contains sensitive properties so that the
user knows to check those steps after the import is complete.
@PaulStovell
Copy link
Member

Thanks for the pull request and sorry it took so long to take a look at it. We ended up building a fully-fledged migration tool for 3.0, and these import/export tools are going to be obsolete. For that reason I'll close this PR.

@PaulStovell PaulStovell closed this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants