Allow users to specify multiple Server Comms Addresses to support HA Server configurations #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentron
reviewed
May 23, 2024
| return; | ||
| fi | ||
|
|
||
| echo "Registering additional HA Servers..." |
There was a problem hiding this comment.
It looks like this will allow registering additional instances even non HA?
There was a problem hiding this comment.
The way I have this setup, it uses the ServerUrl to get the thumbprint and stuff, which points to the main server you're registering from. We could allow users to pass in different ServerUrls for each Comms Address, but they would also need to pass in different API keys or bearer tokens for each one too. 🤔
There was a problem hiding this comment.
As discussed here, I think we can continue with this change and add registering with separate server instances later if there is a user call for it.
scme0
force-pushed
the
scme/k8s-agent/add-ha-server-support
branch
from
b25508f
to
1c0adb9
Compare
APErebus
approved these changes
May 24, 2024
kevjt
pushed a commit
that referenced
this pull request
May 29, 2024
…Server configurations (#945) * first pass * Fix formatting * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We need to allow users to specify multiple server comms addresses to support Octopus Server running in an HA configuration.
[sc-75000]
Results
Fortunately, there is already a command in Tentacle that we can leverage to register extra server instances (
poll-server) so I just added an extra variable which can have multiple values, one for each additional server to register.To make things backwards compatible, I've kept the original variable and now support both in the following way:
If
ServerCommsAddress(singular) is set, it will use that for the initial registration. In this case, ifServerCommsAddresses(plural) is also set, all those values will be registered viapoll-server.If
ServerCommsAddressis not set, the first value ofServerCommsAddresseswill be used instead, and the remaining values (if any) inServerCommsAddresseswill be registered viapoll-server.Related Helm Chart PR: OctopusDeploy/helm-charts#160