add snapshot publish func #242
Conversation
| return nil, err | ||
| } | ||
|
|
||
| path = fmt.Sprintf("%s?publish=true", path) |
There was a problem hiding this comment.
there is not "command" to publish a snapshot, this parameter is only available as a query parameter and setting it to any value causes it to publish https://github.com/OctopusDeploy/OctopusDeploy/blob/main/source/Octopus.Core/Features/RunbookSnapshots/CreateRunbookSnapshotCommandHandler.cs#L92
| @@ -35,6 +45,10 @@ func (s *RunbookSnapshotService) Add(runbookSnapshot *RunbookSnapshot) (*Runbook | |||
| return nil, err | |||
| } | |||
|
|
|||
| if publish { | |||
| path = fmt.Sprintf("%s?publish=true", path) | |||
There was a problem hiding this comment.
there is not "command" to publish a snapshot, this parameter is only available as a query parameter and setting it to any value causes it to publish https://github.com/OctopusDeploy/OctopusDeploy/blob/main/source/Octopus.Core/Features/RunbookSnapshots/CreateRunbookSnapshotCommandHandler.cs#L92
There was a problem hiding this comment.
Reading go always confuses me... Is it possible to have previous query parameters here? If so do we need to check the existing path?
There was a problem hiding this comment.
yep, spot on. The default path has no parameters on it.
There was a problem hiding this comment.
I am not going to fix this now. It will probably never become a problem
benPearce1
requested review from
IsaacCalligeros95 and
HuyPhanNguyen
and removed request for
domenicsim1
No description provided.