Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Add additional build info properties and parameterize VcsType #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joeypiccola
Copy link

@joeypiccola joeypiccola commented Feb 3, 2022

This PR does two things.

  1. Allows users to set the VcsType used in the build information. Defaults to GitHub.
  2. Add the additional build information properties VcsRoot and VcsCommitNumber. Build information submitted without a VcsRoot is 100% functional but complains about No VCS root configured (shown below).
    image

This may also fix an issue when create-release is called. My create-release job errors with the following.

Creating release...
There was a problem with your request.

 - GitHub: No VCS root configured

Error from Octopus Server (HTTP 400 BadRequest)
Exit code: -7

@joeypiccola joeypiccola marked this pull request as ready for review February 3, 2022 19:13
@@ -107,7 +112,9 @@ steps:
BuildNumber: "$CIRCLE_BUILD_NUM",
BuildUrl: "$CIRCLE_BUILD_URL",
Branch: "$CIRCLE_BRANCH",
VcsType: "GitHub"
VcsType: "<< parameters.vcs_type >>",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably make this dynamic, too, by using << pipeline.project.type >>. See https://circleci.com/docs/2.0/variables#pipeline-values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants