Use DeploymentActionSlugPackage for external feed triggers and add resource schema for primary package references #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to stop telemetry from being sent
eddymoulton
requested changes
May 3, 2024
There was a problem hiding this comment.
A couple of description changes that you can take or leave. I tried to take the wording from the UI where it made sense.
I think we could clean up the tests a little though. The better we get the tests now, the easier bringing this provider up to date will be.
terraform/52-packagefeedcreatereleasetrigger/project_triggers.tf
Outdated
Show resolved
Hide resolved
Co-authored-by: EddyMoulton <eddy@moulton.com.au>
Co-authored-by: EddyMoulton <eddy@moulton.com.au>
eddymoulton
approved these changes
May 6, 2024
rain-on
approved these changes
May 6, 2024
kevjt
deleted the
kevjt/use-deploymentactionslug-for-external-feed-triggers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
DeploymentActionfield toDeploymentActionSlugforpackagereferences.primary_packageresource schema for external feed triggers. This will make it easier to distinguish between the two types of packages in Octopus deployment steps, and is easier to remember than otherwise having to setpackage_reference = nullfor primary packages.space_idfield optional for the external feed trigger resource. This is in line with every other resource in the Octopus TF provider. [sc-77155]space_idin the request to fetch project triggers. This fixes the bug where triggers weren't being successfully retrieved on any space other than the default space. [sc-76114]slugon DeploymentActions so that it can be referenced and used in the specification of external feed triggers