Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for utilities #107

Merged
merged 136 commits into from
Mar 17, 2023
Merged

Unit tests for utilities #107

merged 136 commits into from
Mar 17, 2023

Conversation

stefanhenneking
Copy link
Contributor

@stefanhenneking stefanhenneking commented Mar 16, 2023 •
edited by ac1512

  • decode/ddecode/decode2
  • encod/decod
  • encode_order/decode_order
  • encodg/decodg
  • fact
  • isgn
  • locate_char
  • locate
  • near
  • real_imag
  • cross_product
  • dot_product
  • invert

This PR also adds one specific test (hexa_adapt_h_case1) to test for a previous bug in the code that is resolved in #108.

@stefanhenneking
various updates, modernizing language
441d836
@stefanhenneking
consolidating cross_product routines
e71aaea
@stefanhenneking
implicit none for geom3D
6cb8e04
@stefanhenneking
keep_time f90
6532f36
@stefanhenneking
implicit none geom
d1d0a3a
@stefanhenneking
removing obsolete files in constrs
f843533
@stefanhenneking
removing obsolete routines
06d0986
@stefanhenneking
converting isgn to f90
e464384
@stefanhenneking
removing obsolete module
3926166
@stefanhenneking
moving obsolete file
af45719
@stefanhenneking
moving unused utility routines
f1b9461
@stefanhenneking
locate_char f90
0aa4777
@stefanhenneking
moving unused utility routine
36546b7
@stefanhenneking
updating encod/decod utilities to f90.
ece3245
@stefanhenneking
updated sorting routines to f90
81603bc
@stefanhenneking
updating style of utility routines
0e597fc
@stefanhenneking
updated style of numerics routines and removed obsolete file.
2b3e58f
@stefanhenneking
minor
b5039de
@stefanhenneking
implicit none for max rule routine.
a193ad9
@stefanhenneking
minor
9419532
@stefanhenneking
updated style of datstrs routines
139f1ab
@stefanhenneking
fixed bug - missing initialization
4ec25f6
@stefanhenneking
added debug flags
b23aa64
@stefanhenneking
added implicit none and debug flags
e54a2a0
@stefanhenneking
added implicit none and debug flags
8329b42
@stefanhenneking
moved unused files
66e0d0a
@stefanhenneking
address compiler warnings
f8212f6
@stefanhenneking
implicit none and debug flags
d1d057d
@stefanhenneking
implicit none and debug flags
d3ed1b7
@stefanhenneking
implicit none and debug flags
02092b5
@stefanhenneking stefanhenneking added the WIP Work in progress label Mar 16, 2023
@stefanhenneking stefanhenneking self-assigned this Mar 16, 2023
@stefanhenneking stefanhenneking added the testing Unit tests, etc label Mar 16, 2023
@stefanhenneking stefanhenneking added ready-for-review Ready to be reviewed and removed WIP Work in progress labels Mar 16, 2023
@stefanhenneking stefanhenneking mentioned this pull request Mar 16, 2023
Merged
@stefanhenneking stefanhenneking mentioned this pull request Mar 16, 2023
Open
jbadger95
jbadger95 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@jbadger95 jbadger95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looking forward to having a test suite!

Base automatically changed from test-refine to master March 17, 2023 22:15
@stefanhenneking stefanhenneking merged commit 38da62c into master Mar 17, 2023
@stefanhenneking stefanhenneking deleted the test-util branch March 17, 2023 22:24
@stefanhenneking stefanhenneking removed the ready-for-review Ready to be reviewed label Mar 18, 2023
jdmorap pushed a commit that referenced this pull request Jul 25, 2023
@stefanhenneking @jdmorap
Unit tests for utilities (#107)
ed95a50 
* adding util unit tests

* adding more utility unit tests

* unit test for invert

* removing obsolete tests

* adding a new test case that caused an issue

* new util routine, near
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadger95 jbadger95 jbadger95 approved these changes

Assignees

@stefanhenneking stefanhenneking

Labels
testing Unit tests, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanhenneking @jbadger95