-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some image annotation render outside the image frame #72
Comments
Good bug found! I guess that we are rescaling the images to display them in Explorer and that image annotations are expressed using absolute positioning in pixels to higher definition of images. This would be non trivial though to extrapolate the coordinates of the box to lower scale images. |
I think may be dependent by this other issue Odeuropa/knowledge-graph#10 |
We are not rescaling the images on the Explorer. However, some annotations seem to be out of bound. Let's take this example:
This annotation http://data.odeuropa.eu/source/bba099d9-9ae0-586e-aad6-09861b7b4798#xywh=573,377,55,52 is at coordinates 573:377 which is outside of the image boundaries. So it seems that the images on data.odeuropa.eu have a different size than the ones that have been processed by the image annotation system. Do we resize images somewhere in the process when uploading them? |
No we do not resize the image. But there is a deeper problem: the original image should be https://rkd.nl/nl/explore/images/34340 I can correct this specific case manually, but I doubt we can easily detect and download all of them |
The problem comes from our data, Prathmesh and I will look into this next week |
Note to @mathiaszinnen and me - This should also be done for ODOR-v3 too. |
@prathmeshrmadhu This is not clear to me how to interpret your comment. Do you mean you have something to do for the ODOR-v3 dataset? Or do you mean that you have done everything already and that we should re-process the data? If so, where are the resources? |
Sorry, @rtroncy - This was for an internal point (between me and Mathias), I will edit it. Currently, nothing needs to be done at your end. |
@prathmeshrmadhu Can you please update us on this issue? |
If I recall correctly, we updated the metadata and image files to fix the issue. I do see now, however, that the issue in the example @ehrhart linked still persists. Maybe it can be fixed by incorporating the latest metadata and image files @pasqLisena? |
@mathiaszinnen Can you provide us again with the link where we can download the latest version of the metadata and the corresponding directory of image files? |
Ok, apparently we were parsing an old version of the annotation, we will fix this in next data release. (keeping this open until next data load) |
For example here https://explorer.odeuropa.eu/smells/2240a201-c1e4-56ed-9d71-f0e082f2f973?q=butter&display=text&page=3&stype=smells&sapi=%2Fapi%2Fsearch&spath=%2Fsmells or here https://explorer.odeuropa.eu/smells/299ac334-5161-5a54-966e-5f6f00b09ee2?q=butter&display=text&page=4&stype=smells&sapi=%2Fapi%2Fsearch&spath=%2Fsmells
The text was updated successfully, but these errors were encountered: