Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some image annotation render outside the image frame #72

Open
kintopp opened this issue May 7, 2023 · 13 comments
Open

Some image annotation render outside the image frame #72

kintopp opened this issue May 7, 2023 · 13 comments
Assignees
Labels
bug Something isn't working priority This issue should be dealt with quickly

Comments

@kintopp kintopp added the bug Something isn't working label May 7, 2023
@rtroncy
Copy link

rtroncy commented May 7, 2023

Good bug found! I guess that we are rescaling the images to display them in Explorer and that image annotations are expressed using absolute positioning in pixels to higher definition of images. This would be non trivial though to extrapolate the coordinates of the box to lower scale images.

@pasqLisena
Copy link
Member

I think may be dependent by this other issue Odeuropa/knowledge-graph#10

@ehrhart
Copy link
Contributor

ehrhart commented May 17, 2023

We are not rescaling the images on the Explorer. However, some annotations seem to be out of bound. Let's take this example:

This annotation http://data.odeuropa.eu/source/bba099d9-9ae0-586e-aad6-09861b7b4798#xywh=573,377,55,52 is at coordinates 573:377 which is outside of the image boundaries.

So it seems that the images on data.odeuropa.eu have a different size than the ones that have been processed by the image annotation system. Do we resize images somewhere in the process when uploading them?

@pasqLisena
Copy link
Member

No we do not resize the image.

But there is a deeper problem: the original image should be https://rkd.nl/nl/explore/images/34340
So, we uploaded at that uri an image that is not the correct one.

I can correct this specific case manually, but I doubt we can easily detect and download all of them

@mathiaszinnen
Copy link

The problem comes from our data, Prathmesh and I will look into this next week

@prathmeshrmadhu
Copy link

prathmeshrmadhu commented Jun 2, 2023

Note to @mathiaszinnen and me - This should also be done for ODOR-v3 too.

@rtroncy
Copy link

rtroncy commented Jun 2, 2023

@prathmeshrmadhu This is not clear to me how to interpret your comment. Do you mean you have something to do for the ODOR-v3 dataset? Or do you mean that you have done everything already and that we should re-process the data? If so, where are the resources?

@prathmeshrmadhu
Copy link

Sorry, @rtroncy - This was for an internal point (between me and Mathias), I will edit it. Currently, nothing needs to be done at your end.

@rtroncy
Copy link

rtroncy commented Sep 5, 2023

@prathmeshrmadhu Can you please update us on this issue?

@rtroncy rtroncy assigned prathmeshrmadhu and unassigned ehrhart Sep 5, 2023
@rtroncy rtroncy added the priority This issue should be dealt with quickly label Sep 5, 2023
@mathiaszinnen
Copy link

If I recall correctly, we updated the metadata and image files to fix the issue. I do see now, however, that the issue in the example @ehrhart linked still persists. Maybe it can be fixed by incorporating the latest metadata and image files @pasqLisena?

@rtroncy
Copy link

rtroncy commented Sep 6, 2023

@mathiaszinnen Can you provide us again with the link where we can download the latest version of the metadata and the corresponding directory of image files?

@mathiaszinnen
Copy link

These are the latest image files.
This is the latest metadata file.

@pasqLisena
Copy link
Member

Ok, apparently we were parsing an old version of the annotation, we will fix this in next data release.

(keeping this open until next data load)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority This issue should be dealt with quickly
Projects
None yet
Development

No branches or pull requests

6 participants