Implement support for "strict" mode #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbohz
changed the title
turbohz
commented
Oct 30, 2023
|
This is really nice. Thank you for your effort @turbohz Like I said, you can add |
…xist Fixes first migration failing in --strict mode
Note: - Bindings for queries not used because of: surrealdb/surrealdb#1911 - Backticks required for the randomized names the tests use
Fixes tests made for "sloppy" mode
Fixes tests made for "sloppy" mode
turbohz
force-pushed
the
implement-support-strict-mode
branch
2 times, most recently
from
712e17f
to
5617fb5
Compare
Fixes --strict mode, since no table is used
turbohz
force-pushed
the
implement-support-strict-mode
branch
from
3264867
to
0bad7b0
Compare
Assertion worked in sloppy mode, but was using wrong DB.
Returns empty list. Fixes test cli::branch::remove::fails_to_remove_if_branch_does_not_exist
turbohz
commented
Nov 13, 2023
Migration was applied to the wrong (random named table) that was not used to perform the assertions. Again, sloppy mode allowed this to pass unnoticed.
|
All tests are passing in both strict and sloppy mode. |
turbohz
commented
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
Many tests work with the assumption that the database is in "sloppy" mode, and though I managed to fix plenty of them by tweaking helper functions, some would need more involved changes.
I'd need feedback on how to make more progress with this.