Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL parsing to reflect spec updates #144

Open
lyoshenka opened this issue Feb 28, 2020 · 1 comment
Open

Update URL parsing to reflect spec updates #144

lyoshenka opened this issue Feb 28, 2020 · 1 comment

Comments

@lyoshenka
Copy link
Contributor

Blocked by lbryio/lbry-sdk#2832. Feel free to do this work anytime, but don't merge or deploy it until this is done in the SDK.

We're changing the # (the claim ID char) in URLs to be :, and the : (claim sequence char) to be *.

# will still work for now, but its deprecated. The SDK should accept it and just convert it to : internally. Everything coming out of the SDK should use :

Here are the corresponding spec changes: lbryio/spec@500066a

@tiger5226
Copy link
Collaborator

We don't currently have this column yet. I definitely want to add it, but I might as well add this format. Since no one is using the column it's probably not blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants