Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URL parsing to reflect spec updates #2832

Closed
lyoshenka opened this issue Feb 28, 2020 · 0 comments · Fixed by #3056
Closed

Update URL parsing to reflect spec updates #2832

lyoshenka opened this issue Feb 28, 2020 · 0 comments · Fixed by #3056
Assignees
@lyoshenka
Labels
consider soon Discuss this issue at the next planning meeting, then remove this label

Comments

@lyoshenka
Copy link
Member

lyoshenka commented Feb 28, 2020 •
edited
Loading

We're changing the # (the claim ID char) in URLs to be :, and the : (claim sequence char) to be *.

# will still work for now, but its deprecated. The SDK should accept it and just convert it to : internally. Everything coming out of the SDK should use :.

Here are the corresponding spec changes: lbryio/spec@500066a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyoshenka lyoshenka

Labels
consider soon Discuss this issue at the next planning meeting, then remove this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for spec compliant URL parsing Aenigma/lbry-sdk
2 participants
@lyoshenka @jackrobison