Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove account when user clears app data #440

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When user clears data from Android Settings app, account is not removed, which could cause inconsistencies between local settings for the app and those stored on Odysee.com

What is the new behavior?

User is presented with an activity warning it that the local account will be removed and it should login again. If user clicks on the button, the account will be implicitly removed along app data

Other information

Some spelling could be changed on the activity. Add a "change request" and I will do it

@ktprograms
Copy link
Collaborator

@kekkyojin iirc you can just add stuff to main/AndroidManifest.xml and it'll also be used in the full variant.

The full/AndroidManifest.xml file is only used for nonfree manifest changes, I think.

@kekkyojin
Copy link
Collaborator Author

You were right, @ktprograms - Changed on my latest commit to this PR

@ktprograms
Copy link
Collaborator

@kekkyojin Does it work if you remove the android:manageSpaceActivity tag from the full manifest as well?

@ktprograms
Copy link
Collaborator

Looks good now, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants