Bugfix/wallet loading #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve handling and alerting on various race conditions when wallet file is present on the filesystem but not loaded in memory. Depending on the SDK response, we attempt re-loading the wallet and re-issuing the request.
What was not handled before is a race condition when wallet loading has already been performed by another parallel request to the API (as UI fires them very fast). In this case, SDK fails with an error saying
Wallet at path .+ is already loaded, now we handle this error and transparently re-issue the request again instead of passing error back to the UI causing its failure.