split proxy module and refactor query/caller somewhat #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anbsky
requested changes
May 11, 2020
| @@ -1,17 +1,20 @@ | |||
| package proxy | |||
| package rpcerrors | |||
There was a problem hiding this comment.
After the renaming, it feels like EnsureAuthenticated does not belong in this package anymore.
| @@ -1,17 +1,18 @@ | |||
| package proxy | |||
| package query | |||
There was a problem hiding this comment.
Not sure how I feel about the package being called query, which is just
a wrapper around client JSON-RPC query
The meat of the package logic seems to be in Caller but naming the package after it doesn't sound right either. Maybe proxy? 😂
lyoshenka
force-pushed
the
split-proxy-module
branch
from
ae68e05
to
e1b2fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.