-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
listen block missing tcp_request #75
Comments
I made a fork and was in the process of making some changes and a pull request, but I'm not sure how to handle the If you look at the configuration for HAProxy,
Currently, the |
If you follow the README, then it would just be a list of things and the template needs changing. If you want to separate the actions, conditions and other parameters then both the README and template need some fixing. :) |
I agree that the |
https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#4.2-tcp-request%20connection
And down from there. Currently, I'm mostly interested in the tcp-request
content.
…On Tue, May 8, 2018 at 10:24 AM, Mischa ter Smitten < ***@***.***> wrote:
I agree that the README is a bit cripple (and the implementation might be
too :-)). Can you add a link of the tcp-request documentation. I'll try
to have a look at it soon.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVkiHpo0CuBswoa6NOOOXm7P-iOptgwks5twUhGgaJpZM4TzjkI>
.
--
MK
|
I guess there should be 4 separate options:
With corresponding arguments (e.g. |
Sure, I'll try to take a look at it as soon as I can. :)
…On Tue, May 15, 2018, 23:20 Mischa ter Smitten ***@***.***> wrote:
Can you add them where they're supported.
[image: screenshot from 2018-05-15 22-19-38]
<https://user-images.githubusercontent.com/3392962/40081396-23b1cbca-588e-11e8-9a39-b4d35b2d0d16.png>
And remove the general tcp_request?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVkiN-5be2V-26r1lPkmFNqFjfQbv82ks5tyzimgaJpZM4TzjkI>
.
|
Finally got around to doing the changes. I added new variables tcp_request_content, tcp_request_connection, tcp_request_session and tcp_request_inspect_delay to the templates for listen, backend and frontend. The variable names are a bit long, might also be a tcp_request dict, but tell me what you think. :) |
It's supported there, and also in backend, but this role seems to be missing a parameter for it.
I also noticed, that there's some differences between the template and the README.
The README says:
But the template has action, param and cond like in http_request:
The text was updated successfully, but these errors were encountered: