Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't overwrite /etc/network/intefaces #12

Open
camlafit opened this issue May 27, 2018 · 5 comments
Open

Doesn't overwrite /etc/network/intefaces #12

camlafit opened this issue May 27, 2018 · 5 comments

Comments

@camlafit
Copy link

Role overwrite /etc/network/interface, it doesn't care about network_interfaces_manage_devices value.

We can have yet managed interfaces and want add only new interface without delete existing interfaces. In this case physical interface configuration are removed, bridge added and server lost its network connection after if down/up action .

Should be possible to have an option to create interface without delete /etc/network/interfaces ?

@tersmitten
Copy link
Member

We don't use this functionality, but if you can find a non-intrusive way to implement it I'm not against it :-)

Can you do a proposal?

@camlafit
Copy link
Author

Hello

thanks for your response. I'm not an expert then I'm not sure to have possibility to give a path. I'll try :)

Maybe could be interesting to update readme file with a notice about rewriting all interfaces files.

@tersmitten
Copy link
Member

Feel free to make a pull request for the improved README (before you try the more complex fix)

@nicoangelo
Copy link

nicoangelo commented Apr 29, 2022

Hi. Ran into the same issue with this otherwise great role. I added a solution in our fork, boiling down to setting the following new variable: network_interfaces_template_interfaces_file. It defaults to true resulting in the same behavior as before. Setting it to false will instead just ensure that the config directory is sourced in the interfaces file.

If that sounds reasonable to you, I'm happy to open a PR.

@camlafit
Copy link
Author

camlafit commented May 2, 2022

Hello

Looks great as this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants