Encrypt outgoing messages (relayed) with STARTTLS by default #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersmitten
commented
May 17, 2020
| smtp_tls_note_starttls_offer = yes | ||
| smtp_use_tls = {{ postfix_smtp_tls_security_level != 'none' | ternary('yes', 'no')}} | ||
| smtp_tls_security_level = {{ postfix_smtp_tls_security_level }} | ||
| smtp_tls_note_starttls_offer = {{ postfix_smtp_tls_note_starttls_offer | bool | ternary('yes', 'no') }} |
There was a problem hiding this comment.
If you want to use it without those options, you can do something like this:
postfix_raw_options:
- |
smtp_use_tls = {{ postfix_smtp_tls_security_level != 'none' | ternary('yes', 'no') }}
smtp_tls_security_level = {{ postfix_smtp_tls_security_level}}There was a problem hiding this comment.
Or do you guys think it should be outside the if's
There was a problem hiding this comment.
I'd leave it inside the if, since for some reason someone may want not to use TLS, so flexibility is fine here IMO.
But I'd switch smtp_use_tls completely, as since 2.3, the recommended variable is smtp_tls_security_level instead (I am not sure anyone wants to use older versions in a critical piece of software like an SMTP server).
It depends on whether you want to potentially break old installations or not.
jchrisweaver
pushed a commit
to weaverconsultingllc/ansible-postfix
that referenced
this pull request
Jun 21, 2024
Encrypt outgoing messages (relayed) with STARTTLS by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.