Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit soundness of timestmp inherent in parachain context #144

Open
JoshOrndorff opened this issue Nov 20, 2023 · 1 comment
Open

Revisit soundness of timestmp inherent in parachain context #144

JoshOrndorff opened this issue Nov 20, 2023 · 1 comment

Comments

@JoshOrndorff
Copy link
Contributor

The big question here is What guarantees can parachain runtime's rely on the relay chain validators to enforce with regards to inherent data.

I like the timestamp example because it is concrete. Is it sound for a parachain to have it's own timestamp inherent? You don't want the relay chain validators to accept a block that the collators will reject because of a bad timestamp.

I argue that Tuxedo should offer the parachain runtime the guarantee that its inherents will be valid.

This issue is to assess whether Tuxedo is doing that, and if not to start doing that.
And more broadly, this issue to to follow up with the Substrate community and the FRAME developers to see whether FRAME is doing this correctly.


Relevant Cumulus PR and SE question.

paritytech/cumulus#2658

@JoshOrndorff
Copy link
Contributor Author

Moonbeam is still using the check inherents feature https://github.com/moonbeam-foundation/moonbeam/blob/96cf8898874509d529b03c4da0e07b2787bacb18/runtime/moonbeam/src/lib.rs#L1584C1-L1606C2.

My reach goal would be to basically have the ParachainConstraintChecker trait have another function called fn get_inherent_data_for_checking_inherents(...) -> InherentData. Then impl it similarly to how moonbeam does.

One open question is what exactly goes in the parameters. Maybe block and relay_chain_state_proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant