-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TradableKitty
piece
#171
Open
NadigerAmit
wants to merge
16
commits into
Off-Narrative-Labs:main
Choose a base branch
from
NadigerAmit:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TradableKitty
piece
#171
Commits on Feb 12, 2024
-
Enhanced Kitty piece with 'name' field, extended FreeKittyConstraintC…
…hecker, and introduced TradableKitty for minting, property updates, and buying in the blockchain. Overall Summary: 1. Enhanced the Kitty piece by adding a 'name' field to the KittyData structure. 2. Extended FreeKittyConstraintChecker to support Mint and Breed functionalities. 3. Introduced a new TradableKitty piece with minting, property updating, and buying capabilities. Details: KittyData Enhancement: The KittyData structure now includes a 'name' field, allowing for the storage and retrieval of kitty names. FreeKittyConstraintChecker Extension in kitties piece : FreeKittyConstraintChecker has been expanded to support both existing Breed functionality and the newly added Mint functionality. Introduction of new piece TradableKitty: A new piece, TradableKitty, has been introduced. Functionalities include minting kitties, updating properties (name, price, availability for sale), and enabling buy operations. Integration with Existing Pieces: TradableKitty seamlessly integrates with both existing kitties and the Money piece, leveraging their functionalities.
Configuration menu - View commit details
-
Copy full SHA for b522b1b - Browse repository at this point
Copy the full SHA b522b1bView commit details -
Updated PKG nam and added better description for tradable_kitties car…
…go.toml Updated PKG nam and added better description for tradable_kitties cargo.toml
Configuration menu - View commit details
-
Copy full SHA for 2e0885d - Browse repository at this point
Copy the full SHA 2e0885dView commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 80d2e99 - Browse repository at this point
Copy the full SHA 80d2e99View commit details
Commits on Feb 22, 2024
-
Implement design change and addressed all the review comments. Mainly: 1. Now kitties can updated to tradable kitties and vice versa based on listForSale and DelistFromsale constraint checkers. 2. Support multiple inputs and outputs 3. Remove the is_avilabel_for_sale from tradable kitty 4. Add listForSale , DelistFromSale and Update name and updatePrice for tradable kitty 5. Add Update name for kitty piece.
Configuration menu - View commit details
-
Copy full SHA for 5461173 - Browse repository at this point
Copy the full SHA 5461173View commit details -
Configuration menu - View commit details
-
Copy full SHA for eea8241 - Browse repository at this point
Copy the full SHA eea8241View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f5855b - Browse repository at this point
Copy the full SHA 1f5855bView commit details
Commits on Feb 25, 2024
-
Implement in-order requirement between input and output for multi inp…
…ut txns Implemented below : 1. Removed the out-of-order b/w input & output for Implemented the in-order for below : 1. ListKittyForSale 2. DelistKittyForSale 3. UpdateName 4.UpdatePrice For Breed operation, only 1 tradable kitty can be traded at the same time in the same txn.
Configuration menu - View commit details
-
Copy full SHA for 4d4501b - Browse repository at this point
Copy the full SHA 4d4501bView commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32be05f - Browse repository at this point
Copy the full SHA 32be05fView commit details
Commits on Mar 8, 2024
-
Implement review comments : Main updates : 1. Price of kitty of mage mandatory. 2. DNA duplicate checks removed. 3. Documentation is revisited. 4. Test cases are updated.
Configuration menu - View commit details
-
Copy full SHA for 7b0a12e - Browse repository at this point
Copy the full SHA 7b0a12eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 389576b - Browse repository at this point
Copy the full SHA 389576bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c77120b - Browse repository at this point
Copy the full SHA c77120bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d57f9b1 - Browse repository at this point
Copy the full SHA d57f9b1View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for db5748d - Browse repository at this point
Copy the full SHA db5748dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02aaf78 - Browse repository at this point
Copy the full SHA 02aaf78View commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c4f903 - Browse repository at this point
Copy the full SHA 9c4f903View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e2c908 - Browse repository at this point
Copy the full SHA 9e2c908View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.