fix: Ecdsa384 signatures

OffBlocks · Jan 11, 2024 · 4d2bb03 · 4d2bb03
1 parent 4ce855e
commit 4d2bb03
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/signer.go b/signer.go
@@ -311,7 +311,12 @@ func (k *EcdsaP256SigningKey) Sign(data []byte) ([]byte, error) {
 		return nil, err
 	}
 
-	return append(r.Bytes(), s.Bytes()...), nil
+	rBytes := make([]byte, 32)
+	sBytes := make([]byte, 32)
+	r.FillBytes(rBytes)
+	s.FillBytes(sBytes)
+
+	return append(rBytes, sBytes...), nil
 }
 
 func (k *EcdsaP256SigningKey) GetKeyID() string {
@@ -340,7 +345,12 @@ func (k *EcdsaP384SigningKey) Sign(data []byte) ([]byte, error) {
 		return nil, err
 	}
 
-	return append(r.Bytes(), s.Bytes()...), nil
+	rBytes := make([]byte, 48)
+	sBytes := make([]byte, 48)
+	r.FillBytes(rBytes)
+	s.FillBytes(sBytes)
+
+	return append(rBytes, sBytes...), nil
 }
 
 func (k *EcdsaP384SigningKey) GetKeyID() string {

diff --git a/verifier.go b/verifier.go
@@ -399,10 +399,11 @@ func (k *EcdsaP384VerifyingKey) Verify(data []byte, signature []byte) error {
 
 	bytes := hash.Sum(nil)
 
-	if len(signature) != 64 {
+	if len(signature) != 96 {
 		return errInvalidSignature
 	}
-	rBytes, sBytes := signature[:32], signature[32:]
+	rBytes, sBytes := signature[:48], signature[48:]
+
 	var r, s big.Int
 	r.SetBytes(rBytes)
 	s.SetBytes(sBytes)