refactor: move token-bridge-sdk inside the ui package #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…idge into refactor-remove-sdk-2
…idge into refactor-remove-sdk-2
…idge into refactor-remove-sdk-2
dewanshparashar
commented
Apr 27, 2023
| @@ -1,4 +1,4 @@ | |||
| import { Transaction, AssetType } from 'token-bridge-sdk' | |||
| import { Transaction, AssetType } from '../../../src/token-bridge-sdk' | |||
There was a problem hiding this comment.
token-bridge-sdk alias import was not getting correctly resolved in e2e/tests. Probably because of multiple tsconfig.json at each level. Tried redefining the alias in different tsconfigs but couldn't catch a break.
fionnachan
reviewed
Apr 27, 2023
packages/arb-token-bridge-ui/src/token-bridge-sdk/hooks/__tests__/useBalance.test.tsx
Outdated
Show resolved
Hide resolved
brtkx
reviewed
Apr 27, 2023
| @@ -11,7 +11,7 @@ import { PropsWithChildren } from 'react' | |||
| import { MultiCaller } from '@arbitrum/sdk' | |||
|
|
|||
| // Create a new cache for every test | |||
| const Container = ({ children }: PropsWithChildren<{}>) => ( | |||
| const Container = ({ children }: PropsWithChildren<any>) => ( | |||
There was a problem hiding this comment.
Could we use unknown instead of any here?
| export * from './hooks/arbTokenBridge.types' | ||
| export * from './hooks/useBalance' | ||
| export * from './hooks/useTransactions' | ||
| export * from './util/index' |
There was a problem hiding this comment.
Is there a reason we want to export everything compared to exporting only the methods that are used on token bridge (like we've had it so far)?
There was a problem hiding this comment.
Reverted now to keep the diffs minimal.
dewanshparashar
commented
Apr 28, 2023
| export * from './hooks/arbTokenBridge.types' | ||
| export * from './hooks/useBalance' | ||
| export * from './hooks/useTransactions' | ||
| export * from './util/index' |
There was a problem hiding this comment.
Reverted now to keep the diffs minimal.
packages/arb-token-bridge-ui/src/token-bridge-sdk/hooks/__tests__/useBalance.test.tsx
Outdated
Show resolved
Hide resolved
| @@ -11,7 +11,7 @@ import { PropsWithChildren } from 'react' | |||
| import { MultiCaller } from '@arbitrum/sdk' | |||
|
|
|||
| // Create a new cache for every test | |||
| const Container = ({ children }: PropsWithChildren<{}>) => ( | |||
| const Container = ({ children }: PropsWithChildren<any>) => ( | |||
fionnachan
approved these changes
Apr 28, 2023
spsjvc
changed the title
spsjvc
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #611